From dacd6d2abba1a2c4ef6158b49363cbc58fbce809 Mon Sep 17 00:00:00 2001 From: MaxED <j.maxed@gmail.com> Date: Tue, 27 May 2014 09:22:44 +0000 Subject: [PATCH] Map Analysis mode: "Check overlapping vertices" was setting incorrect total progress value, which could cause a crash in some cases. --- .../BuilderModes/ErrorChecks/CheckOverlappingVertices.cs | 2 +- Source/Plugins/BuilderModes/ErrorChecks/CheckUnknownThings.cs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs b/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs index e769b0517..cad951dd7 100644 --- a/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs +++ b/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs @@ -23,7 +23,7 @@ namespace CodeImp.DoomBuilder.BuilderModes // Constructor public CheckOverlappingVertices() { // Total progress is done when all lines are checked - SetTotalProgress(General.Map.Map.Linedefs.Count / PROGRESS_STEP); + SetTotalProgress(General.Map.Map.Vertices.Count / PROGRESS_STEP); } #endregion diff --git a/Source/Plugins/BuilderModes/ErrorChecks/CheckUnknownThings.cs b/Source/Plugins/BuilderModes/ErrorChecks/CheckUnknownThings.cs index f8d5c83fd..ac51c6560 100644 --- a/Source/Plugins/BuilderModes/ErrorChecks/CheckUnknownThings.cs +++ b/Source/Plugins/BuilderModes/ErrorChecks/CheckUnknownThings.cs @@ -5,7 +5,8 @@ namespace CodeImp.DoomBuilder.BuilderModes.ErrorChecks { [ErrorChecker("Check unknown things", true, 50)] public class CheckUnknownThings : ErrorChecker { - private int PROGRESS_STEP = 1000; + + private const int PROGRESS_STEP = 1000; // Constructor public CheckUnknownThings() { -- GitLab