From fe87760c8c89f14186cb1c6395fe8fe0948dba33 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gustaf=20Alh=C3=A4ll?= <gustaf@hanicef.me>
Date: Thu, 14 Dec 2023 17:15:07 +0100
Subject: [PATCH] Fix buffer overflow in SV_SendPlayerInfo
---
src/netcode/server_connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/netcode/server_connection.c b/src/netcode/server_connection.c
index 258d4cce44..faff7e8dd7 100644
--- a/src/netcode/server_connection.c
+++ b/src/netcode/server_connection.c
@@ -164,7 +164,7 @@ static void SV_SendPlayerInfo(INT32 node)
for (UINT8 i = 0; i < MAXPLAYERS; i++)
{
- if (!netnodes[playernode[i]].ingame)
+ if (playernode[i] == UINT8_MAX || !netnodes[playernode[i]].ingame)
{
netbuffer->u.playerinfo[i].num = 255; // This slot is empty.
continue;
--
GitLab