From 014b93406ed2a605027466f9f3e3815c19e5d77a Mon Sep 17 00:00:00 2001
From: Louis-Antoine <lamr@free.fr>
Date: Fri, 31 Jan 2020 15:29:22 +0100
Subject: [PATCH] Store most data in gamestate instead of server config packet
---
src/d_clisrv.c | 82 +-------------------------------------------------
src/d_clisrv.h | 8 -----
src/p_saveg.c | 19 ++++++++++--
3 files changed, 17 insertions(+), 92 deletions(-)
diff --git a/src/d_clisrv.c b/src/d_clisrv.c
index ee4e62b912..694240579a 100644
--- a/src/d_clisrv.c
+++ b/src/d_clisrv.c
@@ -1117,40 +1117,6 @@ static void GetPackets(void);
static cl_mode_t cl_mode = CL_SEARCHING;
-// Player name send/load
-
-static void CV_SavePlayerNames(UINT8 **p)
-{
- INT32 i = 0;
- // Players in game only.
- for (; i < MAXPLAYERS; ++i)
- {
- if (!playeringame[i])
- {
- WRITEUINT8(*p, 0);
- continue;
- }
- WRITESTRING(*p, player_names[i]);
- }
-}
-
-static void CV_LoadPlayerNames(UINT8 **p)
-{
- INT32 i = 0;
- char tmp_name[MAXPLAYERNAME+1];
- tmp_name[MAXPLAYERNAME] = 0;
-
- for (; i < MAXPLAYERS; ++i)
- {
- READSTRING(*p, tmp_name);
- if (tmp_name[0] == 0)
- continue;
- if (tmp_name[MAXPLAYERNAME]) // overflow detected
- I_Error("Received bad server config packet when trying to join");
- memcpy(player_names[i], tmp_name, MAXPLAYERNAME+1);
- }
-}
-
#ifdef CLIENT_LOADINGSCREEN
//
// CL_DrawConnectionStatus
@@ -1412,8 +1378,6 @@ static void SV_SendPlayerInfo(INT32 node)
*/
static boolean SV_SendServerConfig(INT32 node)
{
- INT32 i;
- UINT8 *p, *op;
boolean waspacketsent;
netbuffer->packettype = PT_SERVERCFG;
@@ -1429,32 +1393,10 @@ static boolean SV_SendServerConfig(INT32 node)
netbuffer->u.servercfg.gametype = (UINT8)gametype;
netbuffer->u.servercfg.modifiedgame = (UINT8)modifiedgame;
- // we fill these structs with FFs so that any players not in game get sent as 0xFFFF
- // which is nice and easy for us to detect
- memset(netbuffer->u.servercfg.playerskins, 0xFF, sizeof(netbuffer->u.servercfg.playerskins));
- memset(netbuffer->u.servercfg.playercolor, 0xFF, sizeof(netbuffer->u.servercfg.playercolor));
- memset(netbuffer->u.servercfg.playeravailabilities, 0xFF, sizeof(netbuffer->u.servercfg.playeravailabilities));
-
- memset(netbuffer->u.servercfg.adminplayers, -1, sizeof(netbuffer->u.servercfg.adminplayers));
-
- for (i = 0; i < MAXPLAYERS; i++)
- {
- netbuffer->u.servercfg.adminplayers[i] = (SINT8)adminplayers[i];
-
- if (!playeringame[i])
- continue;
- netbuffer->u.servercfg.playerskins[i] = (UINT8)players[i].skin;
- netbuffer->u.servercfg.playercolor[i] = (UINT8)players[i].skincolor;
- netbuffer->u.servercfg.playeravailabilities[i] = (UINT32)LONG(players[i].availabilities);
- }
-
memcpy(netbuffer->u.servercfg.server_context, server_context, 8);
- op = p = netbuffer->u.servercfg.varlengthinputs;
- CV_SavePlayerNames(&p);
- CV_SaveNetVars(&p);
{
- const size_t len = sizeof (serverconfig_pak) + (size_t)(p - op);
+ const size_t len = sizeof (serverconfig_pak);
#ifdef DEBUGFILE
if (debugfile)
@@ -3813,9 +3755,6 @@ static void HandlePacketFromAwayNode(SINT8 node)
case PT_SERVERCFG: // Positive response of client join request
{
- INT32 j;
- UINT8 *scp;
-
if (server && serverrunning && node != servernode)
{ // but wait I thought I'm the server?
Net_CloseConnection(node);
@@ -3831,8 +3770,6 @@ static void HandlePacketFromAwayNode(SINT8 node)
maketic = gametic = neededtic = (tic_t)LONG(netbuffer->u.servercfg.gametic);
G_SetGametype(netbuffer->u.servercfg.gametype);
modifiedgame = netbuffer->u.servercfg.modifiedgame;
- for (j = 0; j < MAXPLAYERS; j++)
- adminplayers[j] = netbuffer->u.servercfg.adminplayers[j];
memcpy(server_context, netbuffer->u.servercfg.server_context, 8);
}
@@ -3851,23 +3788,6 @@ static void HandlePacketFromAwayNode(SINT8 node)
#endif
DEBFILE(va("Server accept join gametic=%u mynode=%d\n", gametic, mynode));
- memset(playeringame, 0, sizeof(playeringame));
- for (j = 0; j < MAXPLAYERS; j++)
- {
- if (netbuffer->u.servercfg.playerskins[j] == 0xFF
- && netbuffer->u.servercfg.playercolor[j] == 0xFF
- && netbuffer->u.servercfg.playeravailabilities[j] == 0xFFFFFFFF)
- continue; // not in game
-
- playeringame[j] = true;
- players[j].availabilities = (UINT32)LONG(netbuffer->u.servercfg.playeravailabilities[j]);
- SetPlayerSkinByNum(j, (INT32)netbuffer->u.servercfg.playerskins[j]);
- players[j].skincolor = netbuffer->u.servercfg.playercolor[j];
- }
-
- scp = netbuffer->u.servercfg.varlengthinputs;
- CV_LoadPlayerNames(&scp);
- CV_LoadNetVars(&scp);
#ifdef JOININGAME
/// \note Wait. What if a Lua script uses some global custom variables synched with the NetVars hook?
/// Shouldn't them be downloaded even at intermission time?
diff --git a/src/d_clisrv.h b/src/d_clisrv.h
index df93fe31da..a48ab91a99 100644
--- a/src/d_clisrv.h
+++ b/src/d_clisrv.h
@@ -305,18 +305,10 @@ typedef struct
UINT8 clientnode;
UINT8 gamestate;
- // 0xFF == not in game; else player skin num
- UINT8 playerskins[MAXPLAYERS];
- UINT8 playercolor[MAXPLAYERS];
- UINT32 playeravailabilities[MAXPLAYERS];
-
UINT8 gametype;
UINT8 modifiedgame;
- SINT8 adminplayers[MAXPLAYERS]; // Needs to be signed
char server_context[8]; // Unique context id, generated at server startup.
-
- UINT8 varlengthinputs[0]; // Playernames and netvars
} ATTRPACK serverconfig_pak;
typedef struct {
diff --git a/src/p_saveg.c b/src/p_saveg.c
index 8538568804..19c5b532e3 100644
--- a/src/p_saveg.c
+++ b/src/p_saveg.c
@@ -107,13 +107,16 @@ static void P_NetArchivePlayers(void)
for (i = 0; i < MAXPLAYERS; i++)
{
+ WRITESINT8(save_p, (SINT8)adminplayers[i]);
+
if (!playeringame[i])
continue;
flags = 0;
- // no longer send ticcmds, player name, skin, or color
+ // no longer send ticcmds
+ WRITESTRINGN(save_p, player_names[i], MAXPLAYERNAME);
WRITEANGLE(save_p, players[i].aiming);
WRITEANGLE(save_p, players[i].drawangle);
WRITEANGLE(save_p, players[i].awayviewaiming);
@@ -140,6 +143,9 @@ static void P_NetArchivePlayers(void)
WRITEUINT16(save_p, players[i].flashpal);
WRITEUINT16(save_p, players[i].flashcount);
+ WRITEUINT8(save_p, players[i].skincolor);
+ WRITEINT32(save_p, players[i].skin);
+ WRITEUINT32(save_p, players[i].availabilities);
WRITEUINT32(save_p, players[i].score);
WRITEFIXED(save_p, players[i].dashspeed);
WRITESINT8(save_p, players[i].lives);
@@ -314,6 +320,8 @@ static void P_NetUnArchivePlayers(void)
for (i = 0; i < MAXPLAYERS; i++)
{
+ adminplayers[i] = (INT32)READSINT8(save_p);
+
// Do NOT memset player struct to 0
// other areas may initialize data elsewhere
//memset(&players[i], 0, sizeof (player_t));
@@ -321,9 +329,8 @@ static void P_NetUnArchivePlayers(void)
continue;
// NOTE: sending tics should (hopefully) no longer be necessary
- // sending player names, skin and color should not be necessary at all!
- // (that data is handled in the server config now)
+ READSTRINGN(save_p, player_names[i], MAXPLAYERNAME);
players[i].aiming = READANGLE(save_p);
players[i].drawangle = READANGLE(save_p);
players[i].awayviewaiming = READANGLE(save_p);
@@ -350,6 +357,9 @@ static void P_NetUnArchivePlayers(void)
players[i].flashpal = READUINT16(save_p);
players[i].flashcount = READUINT16(save_p);
+ players[i].skincolor = READUINT8(save_p);
+ players[i].skin = READINT32(save_p);
+ players[i].availabilities = READUINT32(save_p);
players[i].score = READUINT32(save_p);
players[i].dashspeed = READFIXED(save_p); // dashing speed
players[i].lives = READSINT8(save_p);
@@ -3983,6 +3993,7 @@ static void P_NetArchiveMisc(void)
WRITEINT16(save_p, gamemap);
WRITEINT16(save_p, gamestate);
+ WRITEINT16(save_p, gametype);
{
UINT32 pig = 0;
@@ -4065,6 +4076,8 @@ static inline boolean P_NetUnArchiveMisc(void)
G_SetGamestate(READINT16(save_p));
+ gametype = READINT16(save_p);
+
{
UINT32 pig = READUINT32(save_p);
for (i = 0; i < MAXPLAYERS; i++)
--
GitLab