From e0ea677ca42c43715332c9a12b8f55e3e89f2900 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gustaf=20Alh=C3=A4ll?= <gustaf@hanicef.me>
Date: Wed, 30 Aug 2023 19:32:13 +0200
Subject: [PATCH] Make chat spam protection more configurable
---
src/d_netcmd.c | 5 ++++-
src/g_game.c | 4 +++-
src/g_game.h | 2 +-
src/hu_stuff.c | 36 +++++++++++++++++++++++++-----------
4 files changed, 33 insertions(+), 14 deletions(-)
diff --git a/src/d_netcmd.c b/src/d_netcmd.c
index 33281e9924..4d9779a977 100644
--- a/src/d_netcmd.c
+++ b/src/d_netcmd.c
@@ -619,6 +619,10 @@ void D_RegisterServerCommands(void)
CV_RegisterVar(&cv_addons_folder);
CV_RegisterVar(&cv_dummyconsvar);
+
+ CV_RegisterVar(&cv_chatspamprotection);
+ CV_RegisterVar(&cv_chatspamspeed);
+ CV_RegisterVar(&cv_chatspamburst);
}
// =========================================================================
@@ -762,7 +766,6 @@ void D_RegisterClientCommands(void)
CV_RegisterVar(&cv_chatheight);
CV_RegisterVar(&cv_chatwidth);
CV_RegisterVar(&cv_chattime);
- CV_RegisterVar(&cv_chatspamprotection);
CV_RegisterVar(&cv_chatbacktint);
CV_RegisterVar(&cv_consolechat);
CV_RegisterVar(&cv_chatnotifications);
diff --git a/src/g_game.c b/src/g_game.c
index 9780bcd4d2..4dc84b328e 100644
--- a/src/g_game.c
+++ b/src/g_game.c
@@ -304,7 +304,9 @@ consvar_t cv_chatheight= CVAR_INIT ("chatheight", "8", CV_SAVE, chatheight_cons_
consvar_t cv_chatnotifications= CVAR_INIT ("chatnotifications", "On", CV_SAVE, CV_OnOff, NULL);
// chat spam protection (why would you want to disable that???)
-consvar_t cv_chatspamprotection= CVAR_INIT ("chatspamprotection", "On", CV_SAVE, CV_OnOff, NULL);
+consvar_t cv_chatspamprotection= CVAR_INIT ("chatspamprotection", "On", CV_SAVE|CV_NETVAR, CV_OnOff, NULL);
+consvar_t cv_chatspamspeed= CVAR_INIT ("chatspamspeed", "35", CV_SAVE|CV_NETVAR, CV_Unsigned, NULL);
+consvar_t cv_chatspamburst= CVAR_INIT ("chatspamburst", "3", CV_SAVE|CV_NETVAR, CV_Unsigned, NULL);
// minichat text background
consvar_t cv_chatbacktint = CVAR_INIT ("chatbacktint", "On", CV_SAVE, CV_OnOff, NULL);
diff --git a/src/g_game.h b/src/g_game.h
index a8c285f79f..cdaf7d2f57 100644
--- a/src/g_game.h
+++ b/src/g_game.h
@@ -51,7 +51,7 @@ extern consvar_t cv_pauseifunfocused;
// used in game menu
extern consvar_t cv_tutorialprompt;
-extern consvar_t cv_chatwidth, cv_chatnotifications, cv_chatheight, cv_chattime, cv_consolechat, cv_chatbacktint, cv_chatspamprotection, cv_compactscoreboard;
+extern consvar_t cv_chatwidth, cv_chatnotifications, cv_chatheight, cv_chattime, cv_consolechat, cv_chatbacktint, cv_chatspamprotection, cv_chatspamspeed, cv_chatspamburst, cv_compactscoreboard;
extern consvar_t cv_crosshair, cv_crosshair2;
extern consvar_t cv_invertmouse, cv_alwaysfreelook, cv_chasefreelook, cv_mousemove;
extern consvar_t cv_invertmouse2, cv_alwaysfreelook2, cv_chasefreelook2, cv_mousemove2;
diff --git a/src/hu_stuff.c b/src/hu_stuff.c
index 091e2b2fba..11c2a9e3d0 100644
--- a/src/hu_stuff.c
+++ b/src/hu_stuff.c
@@ -630,7 +630,9 @@ static void Command_CSay_f(void)
DoSayCommand(0, 1, HU_CSAY);
}
-static tic_t stop_spamming[MAXPLAYERS];
+
+static tic_t spam_tokens[MAXPLAYERS];
+static tic_t spam_tics[MAXPLAYERS];
/** Receives a message, processing an ::XD_SAY command.
* \sa DoSayCommand
@@ -682,14 +684,14 @@ static void Got_Saycmd(UINT8 **p, INT32 playernum)
// before we do anything, let's verify the guy isn't spamming, get this easier on us.
//if (stop_spamming[playernum] != 0 && cv_chatspamprotection.value && !(flags & HU_CSAY))
- if (stop_spamming[playernum] != 0 && consoleplayer != playernum && cv_chatspamprotection.value && !(flags & HU_CSAY))
+ if (spam_tokens[playernum] <= 0 && cv_chatspamprotection.value && !(flags & HU_CSAY))
{
CONS_Debug(DBG_NETPLAY,"Received SAY cmd too quickly from Player %d (%s), assuming as spam and blocking message.\n", playernum+1, player_names[playernum]);
- stop_spamming[playernum] = 4;
+ spam_tics[playernum] = 0;
spam_eatmsg = 1;
}
else
- stop_spamming[playernum] = 4; // you can hold off for 4 tics, can you?
+ spam_tokens[playernum] -= 1;
// run the lua hook even if we were supposed to eat the msg, netgame consistency goes first.
@@ -871,6 +873,25 @@ static void Got_Saycmd(UINT8 **p, INT32 playernum)
//
void HU_Ticker(void)
{
+ // do this server-side, too
+ if (netgame)
+ {
+ size_t i = 0;
+
+ // handle spam while we're at it:
+ for(; (i<MAXPLAYERS); i++)
+ {
+ if (spam_tokens[i] < (tic_t)cv_chatspamburst.value)
+ {
+ if (++spam_tics[i] >= (tic_t)cv_chatspamspeed.value)
+ {
+ spam_tokens[i]++;
+ spam_tics[i] = 0;
+ }
+ }
+ }
+ }
+
if (dedicated)
return;
@@ -894,13 +915,6 @@ void HU_Ticker(void)
{
size_t i = 0;
- // handle spam while we're at it:
- for(; (i<MAXPLAYERS); i++)
- {
- if (stop_spamming[i] > 0)
- stop_spamming[i]--;
- }
-
// handle chat timers
for (i=0; (i<chat_nummsg_min); i++)
{
--
GitLab