From fd4d3a6a692ebc3605d697e5d90307fe9db09ff4 Mon Sep 17 00:00:00 2001
From: mazmazz <mar.marcoz@outlook.com>
Date: Sun, 4 Aug 2019 02:11:04 -0400
Subject: [PATCH] Mixer X menu touchup
---
src/m_menu.c | 34 +++++++++++++++++++++++-----------
src/sdl/mixer_sound.c | 2 +-
2 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/src/m_menu.c b/src/m_menu.c
index 560b28be89..68f5274737 100644
--- a/src/m_menu.c
+++ b/src/m_menu.c
@@ -1308,24 +1308,36 @@ static menuitem_t OP_SoundOptionsMenu[] =
{IT_HEADER, NULL, "Accessibility", NULL, 103}, // 50
{IT_STRING | IT_CVAR, NULL, "Closed Captioning", &cv_closedcaptioning, 115}, // 56
-#ifdef HAVE_OPENMPT
- {IT_HEADER, NULL, "OpenMPT Settings", NULL, 133},
- {IT_STRING | IT_CVAR, NULL, "Instrument Filter", &cv_modfilter, 145},
-#endif
-#ifdef HAVE_MIXERX
- {IT_STRING | IT_SUBMENU, NULL, "Advanced Settings...", &OP_SoundAdvancedDef, 163},
+#if defined(HAVE_OPENMPT) || defined(HAVE_MIXERX)
+ {IT_STRING | IT_SUBMENU, NULL, "Advanced Settings...", &OP_SoundAdvancedDef, 133},
#endif
};
-#ifdef HAVE_MIXERX
+#if defined(HAVE_OPENMPT) || defined(HAVE_MIXERX)
+
+#ifdef HAVE_OPENMPT
+#define OPENMPT_MENUOFFSET 32
+#else
+#define OPENMPT_MENUOFFSET 0
+#endif
+
static menuitem_t OP_SoundAdvancedMenu[] =
{
- {IT_HEADER, NULL, "MIDI", NULL, 10},
+#ifdef HAVE_OPENMPT
+ {IT_HEADER, NULL, "OpenMPT Settings", NULL, 10},
+ {IT_STRING | IT_CVAR, NULL, "Instrument Filter", &cv_modfilter, 22},
+#endif
- {IT_STRING | IT_CVAR, NULL, "MIDI Player", &cv_midiplayer, 22},
- {IT_STRING | IT_CVAR | IT_CV_STRING, NULL, "FluidSynth Sound Font File", &cv_midisoundfontpath, 32},
- {IT_STRING | IT_CVAR | IT_CV_STRING, NULL, "TiMidity++ Config Folder", &cv_miditimiditypath, 60}
+#ifdef HAVE_MIXERX
+ {IT_HEADER, NULL, "MIDI Settings", NULL, OPENMPT_MENUOFFSET+10},
+ {IT_STRING | IT_CVAR, NULL, "MIDI Player", &cv_midiplayer, OPENMPT_MENUOFFSET+22},
+ {IT_STRING | IT_CVAR | IT_CV_STRING, NULL, "FluidSynth Sound Font File", &cv_midisoundfontpath, OPENMPT_MENUOFFSET+34},
+ {IT_STRING | IT_CVAR | IT_CV_STRING, NULL, "TiMidity++ Config Folder", &cv_miditimiditypath, OPENMPT_MENUOFFSET+61}
+#endif
};
+
+#undef OPENMPT_MENUOFFSET
+
#endif
static menuitem_t OP_DataOptionsMenu[] =
diff --git a/src/sdl/mixer_sound.c b/src/sdl/mixer_sound.c
index dd9aaaef40..aa29d0ef27 100644
--- a/src/sdl/mixer_sound.c
+++ b/src/sdl/mixer_sound.c
@@ -190,7 +190,7 @@ static void MidiSoundfontPath_Onchange(void)
// which happens when: defined(HAVE_MIXERX) && !defined(HAVE_MIXER)
static CV_PossibleValue_t midiplayer_cons_t[] = {{MIDI_OPNMIDI, "OPNMIDI"}, {MIDI_Fluidsynth, "Fluidsynth"}, {MIDI_Timidity, "Timidity"}, {MIDI_Native, "Native"}, {0, NULL}};
consvar_t cv_midiplayer = {"midiplayer", "OPNMIDI" /*MIDI_OPNMIDI*/, CV_CALL|CV_NOINIT|CV_SAVE, midiplayer_cons_t, Midiplayer_Onchange, 0, NULL, NULL, 0, 0, NULL};
-consvar_t cv_midisoundfontpath = {"midisoundfont", "sf2/8bit.sf2", CV_CALL|CV_NOINIT|CV_SAVE, NULL, MidiSoundfontPath_Onchange, 0, NULL, NULL, 0, 0, NULL};
+consvar_t cv_midisoundfontpath = {"midisoundfont", "sf2/8bitsf.SF2", CV_CALL|CV_NOINIT|CV_SAVE, NULL, MidiSoundfontPath_Onchange, 0, NULL, NULL, 0, 0, NULL};
consvar_t cv_miditimiditypath = {"midisoundbank", "./timidity", CV_SAVE, NULL, NULL, 0, NULL, NULL, 0, 0, NULL};
#endif
--
GitLab