[next] Z_Free:wrong id when a netgame ends.

compiled off commit 07650041 in next, any form of a netgame being ended, etc server shutting down or leaving manually. Causes the game to crash with Z_Free:wrong id.

changed the description

changed title from [next: commit 07650041] Z_Free:wrong id when a netgame ends. to [next: in state of commit 07650041] Z_Free:wrong id when a netgame ends.

Interesting, the zone allocator isn't used in the code at all...

I cannot seem to recreate this Z_Free error, try compiling with ZDEBUG=1

changed title from [next: in state of commit 07650041] Z_Free:wrong id when a netgame ends. to [next] Z_Free:wrong id when a netgame ends.

changed the description

https://git.do.srb2.org/STJr/SRB2/blob/next/src/command.c#L1787 This seems to be the trigger point, function is called by CL_Reset finding the root cause of this will require going deeper.

mentioned in merge request !1426 (merged)

added Bug and removed Regression labels

removed milestone

I have not been able to recreate this either, I tried using a built linux executable and wine. Has anyone else on bare windows been able to re-create this?

So far, there is no known way to reproduce the crash consistently

I'm able to reproduce this consistently on Linux

1. Host your own server: ./lsdl2srb2 -dedicated -warp mapmb -gametype match
2. Join the server: ./lsdl2srb2 -connect your.server.ip.address -port 5030
3. ESC->Return To Title
4. Connect to the server again: connect your.server.ip.address
5. ESC->Return To Title again
6. Z_free: wrong id

Yeah that's what I thought too, until it mysteriously stopped happening the next day, it'll most likely end up being the same for you

Thus my previous comment

I noticed that it doesn't happen on Co-op gametype. It happens on Match/CTF and it breaks when it tries to Z_Free(cvar->revert.v.string). It happens when it reaches the timelimit or pointlimit consvars. It would be nice if you can confirm this.

When I reported the issue initially it was on Co-op

I've also had this issue happen with a Co-op netgame I hosted, so it also happens with non-dedicated servers.

mentioned in merge request !1477 (merged)

closed via merge request !1477 (merged)

mentioned in commit 1e394a80

mentioned in merge request !1479 (merged)

mentioned in commit 83a80106