If a client requests a file then goes silent, the server will resend the file endlessly
I only sent a single PT_REQUESTFILE packet, and now this is happening:
Notice the iteration count is 0, when it's supposed to start at 1...that's because it did start at 1, and overflowed the 8-bit integer. And it's still going strong, past 2000 packets. I can't possibly imagine this is intended behavior. While I sent the packet using my own script, I imagine the same thing can easily happen if a client's connection drops right after requesting a file.
(If you're interested in my Wireshark dissector script, you can get that from here: https://gist.github.com/flarn2006/2611b84101cdc48f954528479d7ddda0)
EDIT: And it's still going, more than an hour later.