player->skin should reflect the skin name rather than the skin number
Skin numbers come with the inherent design flaw of inconsistency when skins are loaded out of order. This was why !1503 (merged) was merged, since it would mess with custom saves. player->skin
should use the skin's name in the form of a string to prevent this from ever happening. I mean, the global table skins
can already accept skin names instead of numbers (skins["sonic"].name
would return "sonic" for example), and player->mo->skin
uses a skin name rather than a number. Even if checking skins[player->skin].name
will get you the current skin's name, it would be much more tidy to only ever have to check player->skin
directly.