Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • SRB2 SRB2
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 405
    • Issues 405
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 138
    • Merge requests 138
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • STJr
  • SRB2SRB2
  • Issues
  • #913

Closed
Open
Created Nov 20, 2022 by Zwip-Zwap Zapony@Zwip-Zwap_ZaponyContributor

[CMake?] libdivide and libgme cause compile warnings

libdivide and libgme cause warnings when compiling (at least when using CMake), preventing the game from being compiled with SRB2_CONFIG_ERRORMODE. This wasn't an issue for me (with MinGW-w64's mingw32-make) prior to the CMakening.

The two/three types of warnings shown are...

D:/SteamLibrary/NonSteam/Games/Sonic/Sonic Robo Blast 2/Source/build/_deps/libgme-src/gme/Hes_Cpu.cpp: In member function 'bool Hes_Cpu::run(hes_time_t)':
D:/SteamLibrary/NonSteam/Games/Sonic/Sonic Robo Blast 2/Source/build/_deps/libgme-src/gme/Hes_Cpu.cpp:878:22: warning: conversion from 'unsigned int' to 'uint_fast16_t' {aka 'short unsigned int'} changes value from '4294967295' to '65535' [-Woverflow]
  878 |                 nz = (unsigned) -1;
      |                      ^~~~~~~~~~~~~

[...]

D:/SteamLibrary/NonSteam/Games/Sonic/Sonic Robo Blast 2/Source/src/libdivide.h: In function 'libdivide_u32_gen':
D:/SteamLibrary/NonSteam/Games/Sonic/Sonic Robo Blast 2/Source/src/libdivide.h:637:24: warning: function returns an aggregate [-Waggregate-return]
  637 | struct libdivide_u32_t libdivide_u32_gen(uint32_t d) {
      |                        ^~~~~~~~~~~~~~~~~
D:/SteamLibrary/NonSteam/Games/Sonic/Sonic Robo Blast 2/Source/src/libdivide.h:638:12: warning: function call has aggregate value [-Waggregate-return]
  638 |     return libdivide_internal_u32_gen(d, 0);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[...]
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking