Fix musintername and muspostbossname sometimes returning garbage.
Fixes #197 (closed)
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
-
1777 1777 else if (fastcmp(word, "MUSICINTERFADEOUT")) 1778 1778 mapheaderinfo[num-1]->musinterfadeout = (UINT32)get_number(word2); 1779 1779 else if (fastcmp(word, "MUSICINTER")) 1780 { 1780 1781 deh_strlcpy(mapheaderinfo[num-1]->musintername, word2, 1781 1782 sizeof(mapheaderinfo[num-1]->musintername), va("Level header %d: intermission music", num)); 1782 else if (fastcmp(word, "MUSICPOSTBOSS")) 1783 mapheaderinfo[num-1]->musintername[6] = 0; -
Owner
These lines after
deh_strlcpyshould be unnecessary. It looks like the issue was just the wrong byte set onmuspostbossname. The issue's example was little hard to read, so I went to confirm it:musname: GFZ1 musintername: muspostboosname: musname: GFZ2 musintername: muspostboosname: ZA musname: VSBOSS musintername: muspostboosname: GFZ1 musname: THZ1 musintername: muspostboosname: e musname: THZ2 musintername: muspostboosname: ot musname: VSBOSS musintername: muspostboosname: THZ2This is just a sample, but
musinternamenever printed garbage.
-
-
closed
Toggle commit list -
Owner
This was closed to not pollute the history with unnecessary commits, see !1076 (merged) for the proper fix.
