Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
SRB2
SRB2
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 265
    • Issues 265
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 74
    • Merge Requests 74
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • STJr
  • SRB2SRB2
  • Merge Requests
  • !1089

Merged
Opened Jul 25, 2020 by Hannu Hanhi@Hannu_Hanhi 
  • Report abuse
Report abuse

Big room fix for OpenGL

This patch fixes some rendering issues with big rooms in OpenGL by using a 64-bit version of R_PointToAngle for culling calculations.

Before:

srb20049

After:

srb20050

(The black void in the after-picture is the culling plane / "draw distance" which could be adjusted in the rendering code if needed)

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://git.do.srb2.org/Hannu_Hanhi/SRB2.git ogl-big-room-fix
git checkout -b Hannu_Hanhi/SRB2-ogl-big-room-fix FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout next
git merge --no-ff Hannu_Hanhi/SRB2-ogl-big-room-fix

Step 4. Push the result of the merge to GitLab

git push origin next

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 1
  • Changes 3
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • James R. @james

    merged

    Aug 03, 2020

    merged

    merged
    Toggle commit list
  • James R. @james

    mentioned in commit f5d9029d

    Aug 03, 2020

    mentioned in commit f5d9029d

    mentioned in commit f5d9029d2a8f493441dacdeec47a2099b69780ff
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: STJr/SRB2!1089
×

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.