Can we just do this please? Thanks. (!1142) · Merge Requests · STJr / SRB2 · GitLab

Can we just do this please? Thanks.

It'd be so much easier for all of us if we could just do this.

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

@james started a discussion on the diff Sep 10, 2020

Resolved by Golden Sep 10, 2020

			Unable to load the diff.
		James R. @james commented Sep 10, 2020 Owner Shouldn't FRACUNIT have the cast? Shouldn't FRACUNIT have the cast? Golden @Golden commented Sep 10, 2020 I've compiled it and haven't found any issues with dividing a double with an integer, I'll go see if there's any problems with that. I've compiled it and haven't found any issues with dividing a double with an integer, I'll go see if there's any problems with that. James R. @james commented Sep 10, 2020 Owner In my experience dividing by an integer produces an integer result in C. In my experience dividing by an integer produces an integer result in C. Golden @Golden commented Sep 10, 2020 That's because you're dividing integers by integers in C. Besides, my C compiler would've given me a warning about it if that were a problem. That's because you're dividing integers by integers in C. Besides, my C compiler would've given me a warning about it if that were a problem. James R. @james commented Sep 10, 2020 Owner No I do mean dividing float/double by an integer. And it doesn't produce a warning either, the integer result just gets converted back to floating point, but truncated of course. No I do mean dividing float/double by an integer. And it doesn't produce a warning either, the integer result just gets converted back to floating point, but truncated of course. Golden @Golden commented Sep 10, 2020 `print(string.format("%f", FRACUNIT/2))` I want you to compile this branch and give me your results with this Lua code. It should be something like `0.500000` ```lua print(string.format("%f", FRACUNIT/2)) ``` I want you to compile this branch and give me your results with this Lua code. It should be something like `0.500000` Golden @Golden commented Sep 10, 2020 If it ends up printing `0.000000`, then this problem exists. If it ends up printing `0.000000`, then this problem exists. James R. @james commented Sep 10, 2020 Owner You can hand me my clown license, it does work. And now I wonder what I was thinking of because I can't produce anything similar through testing. You can hand me my clown license, it does work. And now I wonder what I was thinking of because I can't produce anything similar through testing. Golden @Golden commented Sep 10, 2020 Interesting, I might be more careful with math between data types in the future, but I think that settles this debate. Interesting, I might be more careful with math between data types in the future, but I think that settles this debate. Please register or sign in to reply

Golden @Golden
resolved all discussions
Sep 10, 2020

resolved all discussions

resolved all discussions

Toggle commit list
SteelT @SteelTitanium
merged
Sep 11, 2020

merged

merged

Toggle commit list
SteelT @SteelTitanium
mentioned in commit 90302330
Sep 11, 2020

mentioned in commit 90302330

mentioned in commit 90302330edb96acf6725be8c018e8b66a6ed6f67

Toggle commit list

Please register or to comment