Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
SRB2
SRB2
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 265
    • Issues 265
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 74
    • Merge Requests 74
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • STJr
  • SRB2SRB2
  • Merge Requests
  • !1154

Merged
Opened Sep 21, 2020 by Lachlan Wright@Lach 
  • Report abuse
Report abuse

Prevent Canarivore gas from teleporting up walls

Thanks to Dead for finding this issue.

GIF

  • Discussion 8
  • Commits 2
  • Changes 1
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • toaster @toaster commented Sep 21, 2020
    Master

    mf_noclipthing is incorrect and will prevent player hazard interaction. you want mf_noclip|mf_noclipheight

    Edited Sep 21, 2020 by toaster
    ~~mf_noclipthing is incorrect and will prevent player hazard interaction. you want mf_noclip|mf_noclipheight~~
  • toaster @toaster commented Sep 21, 2020
    Master

    wait no you don't. just remove all noclip properties and just have special alone

    wait no you don't. just remove all noclip properties and just have special alone
  • Zolton Auburn @Zippy_Zolton commented Sep 21, 2020

    I'm going to edit this in SOC to test out all your different suggestions and the original MR

    I'm going to edit this in SOC to test out all your different suggestions and the original MR
  • Zolton Auburn @Zippy_Zolton commented Sep 21, 2020

    MF_NOCLIPTHING|MF_SPECIAL fixes the issue, prevents player interaction like toaster said

    srb20627

    MF_NOCLIP|MF_NOCLIPHEIGHT|MF_SPECIAL fixes the issue

    srb20628

    MF_SPECIAL also fixes the issue... there seems to be no difference with the above but I think it would be best to have MF_NOCLIPHEIGHT just in case.

    srb20629

    Edited Sep 22, 2020 by Zolton Auburn
    `MF_NOCLIPTHING|MF_SPECIAL` fixes the issue, prevents player interaction like toaster said ![srb20627](/uploads/a2ce16da623ccede48a3adc0a3b617bf/srb20627.gif) `MF_NOCLIP|MF_NOCLIPHEIGHT|MF_SPECIAL` fixes the issue ![srb20628](/uploads/546359783e514bee390c390ced6cdf1b/srb20628.gif) `MF_SPECIAL` also fixes the issue... there seems to be no difference with the above but I think it would be best to have MF_NOCLIPHEIGHT just in case. ![srb20629](/uploads/0c31efb19a091582fbc77fd315ee0a3e/srb20629.gif)
  • Lachlan Wright @Lach commented Sep 22, 2020
    Master

    Oh, interesting; I was under the impression that MF_NOCLIPTHING was just MF_NOCLIP but with wall collision. (The wiki pitches it that way.) I should have done more research, thanks for the catch!

    MF_SPECIAL alone is the best case here; MF_NOCLIPHEIGHT makes it so that objects can fall through the floor, which is not the intended behavior for the gas.

    Oh, interesting; I was under the impression that MF_NOCLIPTHING was just MF_NOCLIP but with wall collision. ([The wiki pitches it that way](https://wiki.srb2.org/wiki/Object_flags).) I should have done more research, thanks for the catch! MF_SPECIAL alone is the best case here; MF_NOCLIPHEIGHT makes it so that objects can fall through the floor, which is not the intended behavior for the gas.
  • Lachlan Wright @Lach

    added 1 commit

    • 9ae20108 - Allow Canarivore gas to interact with players again (oops)

    Compare with previous version

    Sep 22, 2020

    added 1 commit

    • 9ae20108 - Allow Canarivore gas to interact with players again (oops)

    Compare with previous version

    added 1 commit <ul><li>9ae20108 - Allow Canarivore gas to interact with players again (oops)</li></ul> [Compare with previous version](https://git.do.srb2.org/STJr/SRB2/merge_requests/1154/diffs?diff_id=6308&start_sha=5d1a95b9c6fcce021a6d7ad29d263707646abd7b)
    Toggle commit list
  • toaster @toaster commented Sep 22, 2020
    Master

    If the wiki says that, the wiki is incorrect! I like to think of it as:

    • noclip is the cheat code with upwarping
    • noclipheight is falling through the floor but with nogravity is the necessary companion to noclip to prevent upwarping
    • noclipthing is just ignoring all objects regardless of solid or not
    If the wiki says that, the wiki is incorrect! I like to think of it as: - noclip is the cheat code with upwarping - noclipheight is falling through the floor but with nogravity is the necessary companion to noclip to prevent upwarping - noclipthing is just ignoring all objects regardless of solid or not
  • Monster Iestyn @MonsterIestyn commented Sep 22, 2020
    Master

    technically MF_NOCLIP does also ignore all objects though

    Edited Sep 22, 2020 by Monster Iestyn
    technically `MF_NOCLIP` does also ignore all objects though
  • Frostiikin @Frostiikin commented Sep 24, 2020

    I've actually been meaning to ask why it does that for awhile MI, it seems a bit strange that noclip ignores objects, I've ran into problems in the past regarding this, specifically there was this one time where I wanted a projectile to be able to go through walls & floors while still being able to kill badniks, but I just couldn't since noclip also disables enemy collision. If you was to want noclip + no object collision you could just use MF_NOCLIP and MF_NOCLIPTHING at the same time, so it just doesn't make much sense to me why MF_NOCLIP needs no object collision too.

    I've actually been meaning to ask why it does that for awhile MI, it seems a bit strange that noclip ignores objects, I've ran into problems in the past regarding this, specifically there was this one time where I wanted a projectile to be able to go through walls & floors while still being able to kill badniks, but I just couldn't since noclip also disables enemy collision. If you was to want noclip + no object collision you could just use MF_NOCLIP and MF_NOCLIPTHING at the same time, so it just doesn't make much sense to me why MF_NOCLIP needs no object collision too.
  • James R. @james

    merged

    Oct 03, 2020

    merged

    merged
    Toggle commit list
  • James R. @james

    mentioned in commit 27d96bb2

    Oct 03, 2020

    mentioned in commit 27d96bb2

    mentioned in commit 27d96bb21c32d13aa835c7a3001595709b373940
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
Bug
Assign labels
  • View project labels
Reference: STJr/SRB2!1154
×

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.