Skip to content

Remove PF_SPINNING upon use of any jump ability, so that directionchar works properly

Lach requested to merge remove-spinning into next

Late into 2.2's development, the pflag combination PF_SPINNING|PF_THOKKED was granted the movement capabilities of a non-spinning player for the purposes of allowing movement after a wall transfer. A side effect of this change is that some player abilities that keep PF_SPINNING after use also lost their spin-locked controls. While accidental, I think this is a good standard, but the presence of PF_SPINNING also changes the way directionchar behaves, which is not ideal for jump abilities where visual responsiveness to button presses improves player experience.

gif1

This branch makes all of the hardcoded player abilities and all of the hardcoded shield abilities remove PF_SPINNING upon use. (Thanks SMS Alfredo for the catches!)

gif2

Edited by sphere

Merge request reports