Skip to content
Snippets Groups Projects

Add missing entry for SKINCOLOR_BUBBLEGUM in ColorOpposite()

Merged Lach requested to merge (removed):patch-1 into next

Noticed that Lilac didn't have an opposite color; turns out all colors from Purple onwards have opposites that are shifted because Bubblegum's entry was missing from the table.

Picked signpost frame 11 since it's the darkest of the yellows in Popcorn (wouldn't have made sense for it to be grey).

Also this is my first ever merge request (:tada: :tada:) so please let me know if I missed any conventions!

Edited by Sal

Merge request reports

Merged by avatar (May 7, 2025 10:03pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Good oversight-sight!

    Seeing your name on the repo gives me a lot of joy, I was wondering when you were going to build off your Lua knowledge and start playin' with source :D

  • Quick question for the devs, is master for netplay compatible changes like in vanilla SRB2's repo? This unfortunately wouldn't be one of them technically, but I might be just being pedantic. Otherwise, good work on Lach's part. :thumbsup:

  • Author Developer

    Thanks for the encouragement!! I know this change isn't anything major but I've definitely been looking for a baby first step to get into git and modifying source so :)

    If master is for 1.0.4-compatible changes then this should have been merged into next, is that correct?

  • This'll need to wait until I'm moved in -- each color is supposed to have 1 match and I'm pretty sure it's not Popcorn, but I can't check my work files atm

  • Popcorn's OPPOSITECOLOR entry in code is Bubblegum, so if they're all symmetrical matches then this should be correct? Good to check either way

  • Ah -- well still, had an exact shade picked out

  • Author Developer

    Please feel free to change the shade to your intended one! I took an educated guess but I'm no color expert.

  • I'd like it to use 12 instead of 11. I know, kinda picky :p

  • Lach added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    Made the change. Should I also move this to next as per MI's suggestion?

  • Sal changed the description

    changed the description

  • Sal changed target branch from master to next

    changed target branch from master to next

  • merged

  • Sal mentioned in commit ecdfb1dd

    mentioned in commit ecdfb1dd

Please register or sign in to reply
Loading