Bump MAXSKINS up to 64 + fix skin overflow error

changed title from Bump MAXSKINS + fix skin overflow error to Bump MAXSKINS up to 64 + fix skin overflow error

Have you looked at the dehacked/m_menu.c vanilla character select stuff? iirc that's hardcoded to use 32 in some places and maxskins in others

Wait, by changing > to >=, doesn't that mean it would ignore the last skin, making it 63 max? Or am I reading it wrong?

that's fine - numskins starts from 0, but is upped to 1 because sonic is hardcoded. the skins array, meanwhile, is zero indexed. I'm reasonably confident that right now the skin limit is actually 33 instead of 32, so this is necessary to make it a power of 2 properly

Arrays in C are zero-indexed, i.e. they start from index 0 and end at index (arraysize-1). Assuming there are slots for 64 skins, then in fact index 63 is the last skin in this case. So all should be fine, yes.

added 1 commit

• 105958d2 - Update the (unused) SP menu stuff to use MAXSKINS

Compare with previous version

merged

mentioned in commit 3597a94e