Skip to content
Snippets Groups Projects

Fix game trying to load nothing when music and sound files are not present.

Merged Callmore requested to merge Callmore/Kart-Public:map-search-fix into master

Kart used to load maps initally from hard-coded values, it now loads from 0 to the number of main wad files. This would cause sigsegvs from trying to read data from non existant files if sounds.kart and music.kart where not present.

Merge request reports

Merged by SalSal 2 years ago (Nov 12, 2022 10:36pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • It shouldn't be reading from beyond mainwads, but making it search all default files - not just maps.kart (and patch.kart if present) - is undesired. If you change the starting index back, that would be a quicker merge

  • What would be the other downsides of searching all mainwad files instead of just the files that contains maps? The only downside I can think of is that the startup time would be slower, however would also mean that the for loop could remain untouched, and still pick up new files in extra mainwad files (If more where added in the future).

    Without debugging this crash just looks like the game doesn't work, as it just sigsegvs during startup with no messages. Avoiding a situation like that would also avoid headaches from users who decide to forgo required files, causing the load order to change and potenally offsetting the index of the maps file.

  • Good points, plusoned.

  • merged

  • Sal mentioned in commit 7dcc7aaa

    mentioned in commit 7dcc7aaa

Please register or sign in to reply
Loading