Skip to content
Snippets Groups Projects
Commit 04a38a68 authored by toaster's avatar toaster
Browse files

Okay, this is a biggun. Pay attention, everyone. 

Moved the handling of P_PlayerInSpecialSector to P_PlayerAfterThink from P_PlayerThink.
* This allows the player to get hurt on sloped lava surfaces that are moving downwards.
* Also prevents the player from standing on death pits for 1 tic.
* Prevents the player moving 1 extra tic's worth of movement of pain when hit by sector.
* Thankfully, no consequences re conveyors.
* Like, the only consequences I've found have been positive. However, this DOES need to be thoroughly investigated before it can be allowed anywhere near Next itself.
parent a2dabd70
No related branches found
No related tags found
4 merge requests!252OpenGL: Public flatsprite: The Fixening,!203Fixes for Each Time and P_IsObjectOnGroundIn,!131Fixes with respect to sector special touching and slopes,!130Get any patch
Hide whitespace changes
Inline Side-by-side
  • toaster @toaster ·
    Author Contributor

    NOTE: Re "Also prevents the player from standing on death pits for 1 tic" - step by step your way through https://gfycat.com/SolidSelfassuredBoubou or https://gfycat.com/CookedIndolentGalapagosalbatross and see the one tic where you're running on the ground. And yes, this was recorded in 2.1.16. That doesn't happen with this, which is https://gfycat.com/MassiveScornfulFallowdeer or https://gfycat.com/SlushyDarkDutchshepherddog and doesn't have the one tic.

  • toaster @toaster ·
    Author Contributor

    Also, a rundown which I gave for people on a Discord server when quizzed about ramifications:

    [7:39 PM] ghoster: so basically i changed the order of operations
[7:40 PM] ghoster: currently it's:
[7:40 PM] ghoster: tic start -> world moves -> player checks sector specials -> player moves -> end tic(edited)
[7:40 PM] ghoster: my change is:
[7:40 PM] ghoster: tic start -> world moves -> player moves -> player checks sector specials -> end tic(edited)
[7:41 PM] ghoster: this has the advantage of allowing the player to move towards the thing and then touch the lava
[7:42 PM] ghoster: instead of trying to touch, not doing so, then moving forwards to hit it, then it moves away, then trying to touch...
[7:44 PM] boinciel: this sounds fine to me
[7:46 PM] ghoster: it sounds fine
[7:46 PM] ghoster: but i wonder how much assuuuumes
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment