Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
SRB2
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
STJr
SRB2
Commits
7e7ff84f
Unverified
Commit
7e7ff84f
authored
1 year ago
by
Hanicef
Browse files
Options
Downloads
Patches
Plain Diff
Fix buffer overflow when tag bits are set
parent
dfd05c61
No related branches found
No related tags found
2 merge requests
!2355
fix newer versions of mixerx
,
!2194
Fix buffer overflow when tag bits are set
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/taglist.c
+5
-5
5 additions, 5 deletions
src/taglist.c
with
5 additions
and
5 deletions
src/taglist.c
+
5
−
5
View file @
7e7ff84f
...
@@ -180,10 +180,10 @@ void Taggroup_Add (taggroup_t *garray[], const mtag_t tag, size_t id)
...
@@ -180,10 +180,10 @@ void Taggroup_Add (taggroup_t *garray[], const mtag_t tag, size_t id)
if
(
Taggroup_Find
(
group
,
id
)
!=
(
size_t
)
-
1
)
if
(
Taggroup_Find
(
group
,
id
)
!=
(
size_t
)
-
1
)
return
;
return
;
if
(
!
in_bit_array
(
tags_available
,
tag
))
if
(
!
in_bit_array
(
tags_available
,
(
UINT16
)
tag
))
{
{
num_tags
++
;
num_tags
++
;
set_bit_array
(
tags_available
,
tag
);
set_bit_array
(
tags_available
,
(
UINT16
)
tag
);
}
}
// Create group if empty.
// Create group if empty.
...
@@ -220,10 +220,10 @@ static void Taggroup_Add_Init(taggroup_t *garray[], const mtag_t tag, size_t id)
...
@@ -220,10 +220,10 @@ static void Taggroup_Add_Init(taggroup_t *garray[], const mtag_t tag, size_t id)
group
=
garray
[(
UINT16
)
tag
];
group
=
garray
[(
UINT16
)
tag
];
if
(
!
in_bit_array
(
tags_available
,
tag
))
if
(
!
in_bit_array
(
tags_available
,
(
UINT16
)
tag
))
{
{
num_tags
++
;
num_tags
++
;
set_bit_array
(
tags_available
,
tag
);
set_bit_array
(
tags_available
,
(
UINT16
)
tag
);
}
}
// Create group if empty.
// Create group if empty.
...
@@ -271,7 +271,7 @@ void Taggroup_Remove (taggroup_t *garray[], const mtag_t tag, size_t id)
...
@@ -271,7 +271,7 @@ void Taggroup_Remove (taggroup_t *garray[], const mtag_t tag, size_t id)
if
(
group
->
count
==
1
&&
total_elements_with_tag
(
tag
)
==
1
)
if
(
group
->
count
==
1
&&
total_elements_with_tag
(
tag
)
==
1
)
{
{
num_tags
--
;
num_tags
--
;
unset_bit_array
(
tags_available
,
tag
);
unset_bit_array
(
tags_available
,
(
UINT16
)
tag
);
}
}
// Strip away taggroup if no elements left.
// Strip away taggroup if no elements left.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment