Brak's electricity doesn't respect player z position

Hitbox viewer added for demonstration purposes.

added Bug label

Ah, I see what the problem is. Cybrak's electric barrier hitbox is designed to be the same size as Cybrak... at normal scale, but it's scaled up to twice as big. The only reason you don't get hurt when getting near him while he's electrified is because of the blockmap's effective object size limit, but this doesn't apply to vertical. You can see the extremely enlarged hitbox around the edges of the screenshot, and the hitbox particles flickering across the gif as Cybrak moves around. To fix, divide the infotable radius and height properties for MT_CYBRAKDEMON_ELECTRIC_BARRIER by two.

That doesn't make sense, wouldn't it just be contained entirely inside him then? I'd have to ask why it's twice as big instead, that just sounds like somewhere the scale got doubled somehow.

Actually maybe I was jumping too quickly to the suggested "divide it all by two", but I still say maybe the scale is accidentally being scaled to 2x the intended size

I may have scaled the object 2x its original size at some point in 2.2's development to try and get the visual of the sparks to match up with the size of the mech. Changing the radius and height of the electricity to half their original values will maintain the improved aesthetic while correcting the bug that has just been discovered today. Remember that the boss has shootable removed while the barrier is up, so it won't be contained within.

Oh

mentioned in merge request !1294 (merged)

closed via merge request !1294 (merged)

mentioned in commit 7e8fc666