The player is fullbright when using custom lua colors

Affects both Software and OpenGL

if (mobj->color >= FIRSTSUPERCOLOR && mobj->color < numskincolors) // Super colours? Super bright! mobj->frame |= FF_FULLBRIGHT;

might be caused by this in p_mobj.c interpreting all skincolors > SKINCOLOR_ROSY as supercolors

Good eye, it's definitely that line.

TWO POSSIBLE SOLUTIONS:

1. add a boolean for "superbright" into the skincolor struct
2. make the described condition player->powers[pw_super] instead of a numerical check, since I can tell it lives in P_SetPlayerMobjState by eye and therefore can be done via player struct info

I'm partial to 2. because it's a cheap fix for 2.2.5 that's also technically more correct, but 1. could be more useful as an extension in the long term.

PS: no YOU'RE up at 4am because you got distrubed from sleep

I agree with 2 as an easy fix, though I believe checks for SF_SUPER and not SF_NONIGHTSSUPER during CR_NIGHTSMODE may also be needed. I assume nights mode is the reason this wasn't just a pw_super check in the first place.

Oh yep, def relevant for sure. I did think a charflag was necessary to check but forgot which ones and ultimately decided posting outweighed sleep-induced dawdling

mentioned in merge request !1043 (merged)

closed via merge request !1043 (merged)

mentioned in commit 867728ca