Window Quirk

This is minor for OS X. When the game window updates, it always moves to the upper-left side of the screen.

Odd, the code is setup to center the window:

static void SDLSetMode(INT32 width, INT32 height, SDL_bool fullscreen):
        if (window)
        {
                if (fullscreen)
                {
                        wasfullscreen = SDL_TRUE;
                        SDL_SetWindowFullscreen(window, SDL_WINDOW_FULLSCREEN_DESKTOP);
                }
                else if (!fullscreen && wasfullscreen)
                {
                        wasfullscreen = SDL_FALSE;
                        SDL_SetWindowFullscreen(window, 0);
                        SDL_SetWindowSize(window, width, height);
                        SDL_SetWindowPosition(window, SDL_WINDOWPOS_CENTERED_DISPLAY(1), SDL_WINDOWPOS_CENTERED_DISPLAY(1));
                }
                else if (!wasfullscreen)
                {
                        // Reposition window only in windowed mode
                        SDL_SetWindowSize(window, width, height);
                        SDL_SetWindowPosition(window, SDL_WINDOWPOS_CENTERED_DISPLAY(1), SDL_WINDOWPOS_CENTERED_DISPLAY(1));
                }
        }
        else
        {
                Impl_CreateWindow(fullscreen);
                Impl_SetWindowIcon();
                wasfullscreen = fullscreen;
                SDL_SetWindowSize(window, width, height);
                if (fullscreen)
                {
                        SDL_SetWindowFullscreen(window, SDL_WINDOW_FULLSCREEN_DESKTOP);
                }
        }

Who build the SRB2Mac, was it with the old SDL 1.2 interface or the new SDL 2.0 code

I built it. I'm pretty sure i'm using SDL 2.0.

if you run the binary via terminal, you should see a string like so:

Compiled for SDL version: 2.0.5
Linked with SDL version: 2.0.5

Got it in the log: 2.0.4

ok, remove the SDL_SetWindowPosition lines fixes it for me on Linux/GNU, how about on your end?

That did it. It's not centered, but it's certainly better than being obscured.

Should this be closed? The initial issue is fixed, but still isn't quite right - but the person who had these concerns has been satisfied for a while now...

Actually, I don't think any changes were made in the code at all regarding this issue, afaik

Oh, hm. Fair enough.

SDL_WINDOWPOS_CENTERED_DISPLAY(0) fixes it for me.

Hm, wonder if it should be just "SDL_WINDOWPOS_CENTERED", going by documentation for SDL_SetWindowPosition? (https://wiki.libsdl.org/SDL_SetWindowPosition)

(Funnily enough SDL_WINDOWPOS_CENTERED is defined to be SDL_WINDOWPOS_CENTERED_DISPLAY(0) anyway so I'm aware; no idea what effect having 1 instead of 0 is having for the _DISPLAY thing)

EDIT: Ah, the _DISPLAY thing takes a "displayindex" to affect as an argument so I take it

So about this issue, will a proper fix ever be made for it?

mentioned in merge request !210 (merged)

closed via merge request !210 (merged)