Pity shield removes Amy's ability to hammer with jump+spin

See the GIF below.

changed the description

I don't get why CA_TWINSPIN has the option to use spin button at all, it's a jump ability and has nothing to do with shields.

I recall we had problems dealing with Amy's abilities in development, mostly because both the spin and jump abilities happened to use a hammer, and some people expected jump+spin therefore to do something. I think that was why we allowed jump+spin to work?

Amy's hammering control scheme as it stands can be somewhat confusing (though I've personally gotten used to it). Normally the jump+spin hammer ability is overwritten by a shield ability, but since the pity shield doesn't have an ability, it should be an easy fix not to make it erase the jump+spin hammer.

I thought it was a chronic mistake to make spin do Amy's hammer stuff, but was overruled. Every time I see a mb post or git issue on the matter I am vindicated. I legit wish I wasn't, because I'd love for things to be easy and me be wrong, but the can of worms this has opened certainly does not seem worth it.

I didn't post this issue to start discourse around Amy's control scheme. All I'm doing is pointing out a small issue that I'm sure could be easily fixed.

Of course this "issue" is going to start discourse, it's also related to a how CA_TWINSPIN works.

mentioned in merge request !1146 (merged)

closed via merge request !1146 (merged)

mentioned in commit f7e9772e