[2.2.8] CEZ3 indicator arrows don't scale up anymore

Was this an intentional change? I think the arrows being smaller will be harder for new players.

Shot in the dark, I'm guessing this has to do with how mapthings handle scale with the new UDMF features.

Can't be. UDMF only adds, not replace.

Exactly - mapthings didn't used to have scale, that's a new feature that's been added. The MT_LOCKONINF scale is set during P_SpawnMobj, which was fine in earlier versions, but now, its scale is set again during P_SpawnMobjFromMapThing, which occurs after P_SpawnMobj.

There have been previous reports about objects failing to scale on spawn, so all points to UDMF refactoring... though if the arrows make use of type 438, it's their destscale that's set instead, so I can't tell 100% surely that's the case.

Mapthing scale should multiply with scale as given by P_SpawnMobj, not overwrite. Only way to accomodate existing thinkers.

Yeah, I found this out from a Lua scripter reporting problems trying to set scale by Lua, and went to check the code. I told them to use MapThingSpawn as a workaround, but didn't realise it would break anything in use in vanilla... Incidentally, this also breaks what remains of the old "ERZ3 mode" that shrunk everything except the old Brak Eggman boss.

mentioned in merge request !1251 (merged)

closed via merge request !1251 (merged)

mentioned in commit bd9b11a4