Amy rose NPC becomes another Toad in Mario Mode

I don't know why this issue exists. With what I learned from a former dev, Amy was once intended to be unlockable by completing Mario Koopa blast before changing over to frozen hillside.

When I placed NPC amy on a Mario Mode map, instead of NPC amy as I expected, instead I got a Toad!

WHAT

BUP!

I don't know why she gets swapped out. Toad already has a map thing number and is readily placeable in zone builder.

if (mariomode && i == MT_ROSY) return MT_TOAD; // don't remove on penalty of death

This is intentional. Seems to be a developer gag.

well it's st*pid

Gag's over I found a workaround. Amy can be spawned in either via object place or the spawn object linedef action.

I considered not posting this workaround because of the gag because I'm not sure the gag would be removed, or made worse.

Seems like a kinda dumb gag, literally all it does is inconveniences mappers ._.

My hypothesis is that originally MT_TOAD didn't have a thing number assigned so this would've been a funny thing to discover 5 months after the update came out

The actual reason: I coded the Rosy Cameo and put it in FHZ myself, and added this case because I was terrified a now ex-developer was going to forcibly move it to Pipe Towers just to make the Dorkly-tier "princess in another castle" joke, basically ruining the experience of anyone trying to get Amy by making them play through a mediocre returning level. Since Fang and Metal were just unlocked by playing the campaign, several of us felt it was necessary to keep barriers low for her - and a gate behind a high-emblem unlockable showing its age was a bridge too far.

So 50% internal politics and 50% joke.

(I lift the jokey penalty of death if you want it removed, but will not make the change myself)

mentioned in merge request !1183 (merged)

closed via merge request !1183 (merged)

mentioned in commit d7b8d5d0