[next] [Linux?] Game crashes on IsSector3DBlock in any stage containing specifically a scrolling WALL

Self explanatory. Screenshots from my debugger and crash log provided.

OS: Pop!_OS 22.04 LTS
Branch: next

crash-log.txt

wait hold on no this is something else

fresh unmodified next compiled with GCC and I get the issue from trying to change levels at all after going to one

changed title from [next] compiling with Clang on Linux results in a crash at IsSector3DBlock to [next] compiling on Linux results in a crash at IsSector3DBlock??

changed the description

changed title from [next] compiling on Linux results in a crash at IsSector3DBlock?? to [next] Game crashes on IsSector3DBlock in any stage containing specifically a scrolling WALL

a quick dive into the debug info found that all of these crashes share one thing in common. most/all of the sec variable/parameter's data comes back as empty in the memory viewer

changed title from [next] Game crashes on IsSector3DBlock in any stage containing specifically a scrolling WALL to [next] [Linux] Game crashes on IsSector3DBlock in any stage containing specifically a scrolling WALL

changed title from [next] [Linux] Game crashes on IsSector3DBlock in any stage containing specifically a scrolling WALL to [next] [Linux?] Game crashes on IsSector3DBlock in any stage containing specifically a scrolling WALL

Reposting my guesswork from Discord: IsSector3DBlock likely crashes with wall scrollers because for sc_side scrollers, affectee is meant to be a sides index, not a sectors index. There are usually more sidedefs than sectors, so it's possible that affectee is larger than numsectors, and sectors[affectee] as a result is garbage.

So just don't call IsSector3DBlock for sc_side scrollers.

mentioned in merge request !1852 (merged)

mentioned in commit 0b4ceeb7

closed with merge request !1852 (merged)