Skip to content
Snippets Groups Projects

Fix skincolor-related memory leak

Merged James Hale requested to merge Machturne/SRB2:next-lc-uint16 into next

Currently, any change to a skincolor's ramp will cause the entire translation colormap cache to be cleared. Since this doesn't actually free the cached colormaps (since they're freed when PU_LEVEL blocks are purged), they remain in memory. Furthermore, animated skincolors take advantage of the fact that skincolor ramps are R+W and modify them often, worsening the issue and leading to a noticeable, continuous increase in memory usage.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by James R.James R. 4 years ago (Jul 17, 2020 2:01am UTC)

Merge details

  • Changes merged into with 7c2f81e4.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading