Allow modification of built-in skincolors

Modification of built-in skincolors was considered problematic by a former developer, so it was removed during development of !960 (merged). Given that this person is no longer a member of STJr, it was suggested that I reintroduce this feature.

Additionally, minor changes were made:

• The wording of an error was changed to make it more consistent with other errors.
• Previously, an error would be shown only if the length of a skincolor ramp was less than expected. This has been changed so that the error displays when the length is greater than or less than expected.

changed title from Allow built-in color modification to Allow modification of built-in skincolors

changed the description

changed milestone to %2.2.7

added Enhancement label

Are there any concerns re: making standard skincolors inaccessible? If someone was hosting a server where SKINCOLOR_BLUE was inaccessible and someone tried to join while they had that color, would they get booted for an illegal netcmd? What happens if there are no accessible colors in the game? (Genuinely asking - I'm not sure on either of these)

I removed some code from from lib_setskincolor that specifically prevents accessibility changes in !1060 (merged), since at the time you weren't able to modify standard skincolors anyways. If that needs to be reinstated, a similar check should be added for skincolor_set.

You are correct Kays, the player would be kicked. I completely overlooked that. I'll make a commit that disables accessibility changes for standard skincolors shortly.

My earlier assessment was incorrect; if a standard color isn't accessible, then the game searches for one that is. If none are accessible, then the game freezes. In any case, the solution remains as disabling accessibility changes for standard colors.

added 1 commit

• 5332fff5 - Deny standard color accessibility changes

Compare with previous version

merged

mentioned in commit 735942a4