Skip to content
Snippets Groups Projects

Add a menu option for showjoinaddress; disable it by default

Merged Add a menu option for showjoinaddress; disable it by default
showjoinaddress-menu into next
1 unresolved thread
Merged James R. requested to merge showjoinaddress-menu into next
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/m_menu.h
327 327 void *itemaction;
328 328
329 329 // hotkey in menu or y of the item
330 UINT8 alphaKey;
330 UINT16 alphaKey;
  • toaster
    toaster @toaster ·
    Contributor

    Worried about the consequences of this change, as it has been UINT8 for a very long time and I do not know if there are things which rely on the datatype or conversions which would break. Minusoned until you can convince me this change doesn't break anything. (I like everything else about the MR though.)

    Edited by toaster
  • James R.
    James R. @james ·
    Author Owner

    I took a look through m_menu.c. Aside from the cast I just made, everything looks like it doesn't care about UINT8.

  • Zolton Auburn
    Zolton Auburn @Zippy_Zolton ·
    Contributor

    what's the difference?

  • Please register or sign in to reply
  • Zolton Auburn
    Zolton Auburn @Zippy_Zolton ·
    Contributor

    I didn't even know this was an option, but having this off by default would be good for videos and streams

  • James R. added 1 commit

    added 1 commit

    • 30043682 - Cast UINT16 for unlockable_t.height -> alphaKey

    Compare with previous version

  • James R. merged

    merged

  • James R. mentioned in commit 9147474a

    mentioned in commit 9147474a

    • Please register or sign in to reply