Disallow pk3s with extra bytes (!1275) · Merge requests · STJr / SRB2 · GitLab

Snippets Groups Projects

Merged James R. requested to merge holy-zip into next 4 years ago

1 unresolved thread

PK3 files can be exploited to have SRB2 load lumps that are not viewable in SLADE or other ZIP tools. An example by @Golden: zip1ficklezip.pk3

Activity

James R. @james · 4 years ago

Author Owner

I saw some discussion in #hardcoding over whether this needs to be fixed. I think it does because people have hidden questionable things in wads more blatantly before.
Golden @Golden · 4 years ago

Contributor

fickle's gonna be pissed

but alright whatever

it's not like i found this cool or anything sniff
Zolton Auburn @Zippy_Zolton · 4 years ago

Contributor

How was this even done to the files? also rip movienight v5
toaster @toaster started a thread on the diff 4 years ago

src/d_main.c

 				const char *s = M_GetNextParm();
 				if (s) // Check for NULL?
+				{
 					if (!W_VerifyNMUSlumps(s))
 						G_SetGameModified(true);

James R. merged 4 years ago

merged

James R. mentioned in commit 4 years ago

mentioned in commit f180a1fc

Please register or sign in to reply