Send a `quitting` argument to the GameQuit Lua hook.

• Send quitting argument to determine whether we're quitting the game, or just exiting to the title screen.
• Call the Lua hook irregardless if we're playing or not.

I am fine with 1), but against 2), because that hook was intended to be specifically called when a playing session ends ("game" refers to a game session, not the whole game).

How am I supposed to automatically save configs when the game closes consistently then

Maybe just add another parameter that tells Lua whether or not the game was in the middle of a play session? That way you can have the functionality of both if you want.

But I'm curious, if you're removing the if (Playing()) from quitting the game from the title screen, then why not in every other instance that LUAh_GameQuit is called? Seems kinda odd to have an exception for only one version of quitting.

marked as a Work In Progress

changed the description

I have to agree with @SMS_Alfredo that if (Playing) should not only be removed from the code that is called when the quit the game from the title screen, and also, I should expose Playing(), which is a better solution than adding booleans to the GameQuit hook in my opinion, because it can be used for other hooks that don't have a player_t argument as well.

I think your current solution is fine. There is no need for Playing() because the argument given to the hook fills that role better.

unmarked as a Work In Progress

changed the description

Uhhh, you unmarked this as WIP, but nearly all of the if (Playing())s are still intact. Are you sure you want that?

forgot about that, doing now

added 1 commit

• 119d2e9e - Remove the rest of the Playing() checks for GameQuit hook

Compare with previous version

changed the description

merged

mentioned in commit 9ea969b6