Skip to content
Snippets Groups Projects

Make DEBUGMODE=1 builds (finally) compile, run and work in netgames

Merged X.organic requested to merge X.organic/SRB2:debugmode-reborn into next
All threads resolved!

This merge request changes a few things related to DEBUGMODE to make it compile and run properly, even in netgames. Formerly, it would fail to compile due to the Dehacked table sanity check being in a separate source file from the tables, and even before that change or after fixing it, it would segfault on startup due to MOBJCONSISTANCY running even in gamestates where mobjs don't exist, resulting in invalid pointer dereferences. Both are fixed here.

Notably, this MR also makes MOBJCONSISTANCY no longer implicitly enabled by DEBUGMODE in the Makefile, making DEBUGMODE netgame-compatible by default. The MOBJCONSISTANCY make flag still exists for enabling it.

The aforementioned sanity check uses sizeof to get the size of the tables, but a rewrite to make it check size at runtime may be welcome.

Edited by X.organic

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • X.organic added 1 commit

    added 1 commit

    • 0cbf9a79 - Fix indentation in MOBJCONSISTANCY conditional

    Compare with previous version

  • X.organic resolved all discussions

    resolved all discussions

  • X.organic changed title from Fix DEBUGMODE once and for all to Make DEBUGMODE=1 builds (finally) compile, run and work in netgames

    changed title from Fix DEBUGMODE once and for all to Make DEBUGMODE=1 builds (finally) compile, run and work in netgames

  • X.organic changed the description

    changed the description

  • merged

  • LJ Sonic mentioned in commit be496e1b

    mentioned in commit be496e1b

  • Please register or sign in to reply
    Loading