Allow sliders passage through spin gaps (resolves #576)

Restores pre-2.2.9 behavior and makes sense visually.

You should also add PF_SLIDING to P_PlayerShouldUseSpinHeight, since it isn't inherently the same as being in painstate.

i thought that might be redundant, but okay

added 1 commit

• 6286fc8b - add sliding flag to spinheight conditions

Compare with previous version

It is kind of redundant. I think P_PlayerShouldUseSpinHeight should actually call P_PlayerCanEnterSpinGaps instead of duplicating its conditions, but it's better for scripting sanity because otherwise PlayerHeight and PlayerCanEnterSpinGaps hooks have a very weird relationship where PlayerCanEnterSpinGaps is run every tic after PlayerHeight, but not if PlayerHeight has any return value.

merged

mentioned in commit aec209ad

changed milestone to %2.2.10

added Bug label