Exclude MT_BOXSPARKLE from Mario blocks

I noticed that respawnable monitors aren't really usable in Mario blocks because of the sparkles they spawn. I looked at the code and see a long list of objects which should be excluded, and as I expected, that one was missing. So I went ahead and added it to the list.

I still think it might be better to ditch that list and just use a flag for it, so custom objects can be ignored if desired, but at least this fixes the issue with respawnable monitors.

Here's a small map that demonstrates the bug, which can be used to verify the fix.

changed the description

Keep MT_NAMECHECK at the end of the list, but yeah, good for a patch. No flag though.

added 1 commit

• a5cd7647 - move MT_BOXSPARKLE in the list

Compare with previous version

Done. :)

Actually, a flag would be ideal so as to prevent hardcoding in all the exceptions. Not a new flag though, since that would be a waste. Something like MF_NOCLIP, MF_NOCLIPTHING, MF_NOCLIPHEIGHT, MF_SCENERY, or any combination of those would be pretty good candidates.

approved this merge request

merged

mentioned in commit b955c9c4

changed the description

changed milestone to %2.2.10