Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • SRB2 SRB2
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 400
    • Issues 400
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 129
    • Merge requests 129
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • STJr
  • SRB2SRB2
  • Merge requests
  • !1711

Merged
Created Jan 14, 2022 by Hannu Hanhi@Hannu_HanhiContributor

Fix software splats breaking and crashing in skyboxes

  • Overview 0
  • Commits 1
  • Changes 1

Fixes out-of-bounds memory reads in R_ClipVisSprite that cause glitches and crashes when rendering floor sprites in skyboxes or portals.

Method for reproducing the crash:

  1. Load this script, which puts a blue sphere floor sprite into GFZ1's skybox. sw-splat-skybox-crash.lua

  2. Load GFZ1.

  3. Go to this spot, move and look around and it should crash pretty fast. (It does on my computer at least)

srb20458

Test build: (based on next so be careful with your save files)

srb2win_sw-splat-skybox-crash.exe

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: sw-splat-skybox-crash