Skip to content

Fix software splats breaking and crashing in skyboxes

Hannu Hanhi requested to merge Hannu_Hanhi/SRB2:sw-splat-skybox-crash into next

Fixes out-of-bounds memory reads in R_ClipVisSprite that cause glitches and crashes when rendering floor sprites in skyboxes or portals.

Method for reproducing the crash:

  1. Load this script, which puts a blue sphere floor sprite into GFZ1's skybox. sw-splat-skybox-crash.lua

  2. Load GFZ1.

  3. Go to this spot, move and look around and it should crash pretty fast. (It does on my computer at least)

srb20458

Test build: (based on next so be careful with your save files)

srb2win_sw-splat-skybox-crash.exe

Merge request reports