Skip to content

Fix con_hudlines being off by one, Fix con_hudtime overflow

Zwip-Zwap Zapony requested to merge Zwip-Zwap_Zapony/SRB2:hudlines-hudtime-fix into next

Fixes the displayed console HUD lines being one less than the con_hudlines console variable. Previously, con_hudlines 5 resulted in up to 4 lines being shown on the HUD.
(This changes the default behaviour; while the console variable still defaults to 5, it now shows 5 lines on-HUD instead of 4.)
con_hudlines has also been changed to be limited from 0 to MAXHUDLINES (20), instead of being limited from 0 to 999999999 and having an internal value related to it get clamped from 1 to MAXHUDLINES.

Additionally, con_hudtime has been changed to be limited from 0 to 99,999,999 (3 years) instead of 0 to 999,999,999, as 999999999 * TICRATE doesn't fit in a 32-bit integer. While I was at it, its internal variable name has been renamed from cons_msgtimeout to cons_hudtime for consistency.

-

TL;DR:
- con_hudlines is no longer off by one
- Fixed an overflow with con_hudtime

Edited by Zwip-Zwap Zapony

Merge request reports