Skip to content

Improve file search performance on Linux and FreeBSD

Hanicef requested to merge Hanicef/SRB2:improve-file-search-perf-nix into next

currently, SRB2 tries to look up files recursively when searching for game files. while this gives us a flexible system, it can become a performance issue during startup since a lot of files tend to get dumped in the game directory after a while (stuff like downloaded addons, logs, lua files, etc). this can cause startup and load times to increase over time as the amount of files increases, and can even even hit the point where it can take more than 5 seconds to start up!

the cause of these slow load times, though, is a call to stat for every file in the directory. this makes the kernel resolve and look up every file twice, which increases the amount of time it takes to search substantially. fortunately, though, the information we need is already available in dirent on both Linux and FreeBSD, on the d_type field. using that, we can avoid a call to stat for every file (assuming the filesystem supports it). something similar might be also possible to implement on Windows to give the same performance gain, but i don't have a Windows system to develop and test with. if anyone wanna try to add this for Windows, feel free to do so.

Merge request reports