Skip to content
Snippets Groups Projects

Fix IPv6 bans incorrectly banning IPv4 address

Merged Hanicef requested to merge Hanicef/SRB2Classic:fix-ipv6-bans-blocking-ipv4 into next

in certain edge cases when IPv6 bans are applied, unrelated IPv4 address could also be banned. this happened due to a missing check on the protocol type which caused the server to compare IPv4 addresses with IPv6 and vice versa. if there two addresses just so happen to map to the same binary value, an IPv4 player could get banned for seemingly no reason - this is especially true for bans with a submask, since they only match part of the address, and thus reducing the amount of bits that must match.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
Please register or sign in to reply
Loading