Skip to content

Software - Fake contrast fix

Sryder requested to merge Sryder/SRB2:fake-contrast-fix into master

Some background: Doom has a simple fake contrast that it applies on walls, but only on walls that are perfectly horizontal or vertical. SRB2 has kept this.

This leads to only very specific walls currently applying this, and when it does apply it can often look very strange in levels because of SRB2 more often using more diagonals for walls. This fixes the fake contrast so that it's applied to all walls based on their angle (walls facing further to the north/south are 1 light level brighter, walls facing further to the east/west are 1 light level darker, and the more diagonals are not changed).

Unfortunately, this too can present some oddities in levels where it obviously wasn't built for it. My recommendations are: decide whether you want this always on, or always off (which would require just removing the parts which do the fake contrast) and go with that. Or add an option to choose between on or off on a per level, and per linedef basis for mappers. Either way, this branch shows a way to enable it on all walls if desired.

Edited by Sryder

Merge request reports