Skip to content
Snippets Groups Projects

Fix buffer overflow when loading addons through symlinks

Merged Hanicef requested to merge Hanicef/SRB2Classic:fix-buffer-overflow-symlinks into next

When loading addons via a symlink, the buffer to the addon path could overflow if the total path exceeded 256 bytes. This happens because filesearch expects a path that is MAX_WADPATH long, which wasn't supplied by searchWad, causing it to overflow when expanding the absolute path. This patch fixes this by resizing the buffer to MAX_WADPATH bytes, giving it enough space to write the entire absolute path.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading