Skip to content
Snippets Groups Projects

Fix buffer overflow when setting NETVAR string console variable and ensure servername is within MAXSERVERNAME

Merged Fix buffer overflow when setting NETVAR string console variable and ensure servername is within MAXSERVERNAME
Refrag/SRB2:next into next
Merged Re Frag requested to merge Refrag/SRB2:next into next
  1. Jun 04, 2024
    • Re Frag's avatar
      Ensure the servername fits into MAXSERVERNAME before setting it · b16c4df3
      Re Frag authored 
      This commit adds a verification before setting the servername console
variable. We now check that it fits within the MAXSERVERNAME length and
we cancel setting it if it doesn't.
Letting the servername be more than MAXSERVERNAME could lead to crashes
when trying to edit the server name from the menu so, we now avoid
those.
      Unverified
      b16c4df3
  3. May 20, 2024
    • Re Frag's avatar
      Fix buffer overflow when setting a NETVAR string CVar · 68264e72
      Re Frag authored 
      There was a possible buffer overflow if you tried setting a console var
that had the CV_NETVAR and that was of the string type.
The overflow would happen if you were trying to set the console variable
while in a multiplayer / netgame state.

This commit just increases the size of buf to account for everything
that needs to be written to it.
      Unverified
      68264e72