Issue #1230 - Set spectator back to false just for running the hook

Potential fix for #1230 (closed) ... read the discussion in that issue, please.

Copying what I mentioned on Discord.

I think a if (player->spectator) { return false; } statement, or something similar, might be better in the P_PlayerInPain function in p_user.c:977 rather than setting player->spectator = true for the purposes of the hook.

https://git.do.srb2.org/STJr/SRB2/-/blob/next/src/p_user.c#L977

Open to suggestions. This might tie into the player->mo limitations in Lua where player->mo cannot be found as a spectator. player->realmo was created to satisfy this if I recall correctly.

!756 (merged)

A better solution would be to add a P_MobjWasRemoved check on player->mo inside P_PlayerInPain, since this value is actually either NULL or invalidated for 1 tic when a player is about to respawn, which is the cause of the segfault.

Pushed Hanicef's proposed solution directly to next.

closed