Skip to content

Don't traverse the entire HOME directory but for real this time

Hanicef requested to merge Hanicef/SRB2:actually-avoid-traversing-home into next

So, since we're planning to release 2.2.14 soon, I decided to do another check just to make sure that stuff are in proper working order. One of those things I wanted to test was !2396 (merged) to make sure the game no longer froze when I removed the SRB2WADDIR export that I used when starting up the game, as a workaround before the patch got merged.

But it still froze.

At first, I thought that !2396 (merged) was reverted for some reason, but I quickly found out that it wasn't. Instead, while digging around, I found that, somehow, the value that was allocated for the path was never used. As a result, it had the exact same behavior as it did pre-patch. And this somehow slipped through without anyone noticing despite the fact that we were 7 people involved in that patch. How the fuck did such an obvious bug slip through so many of us?! And I was for damn sure that I had tested it and made sure that it actually worked.

Anyway, this time it should be fixed for real. I've tested many times and made sure that SRB2WADDIR is not set during testing, and it launches properly now, not to mention quicker than before.

Merge request reports

Loading