Skip to content
Snippets Groups Projects

Fix buffer overflow when registering a dedicated build server on MS

Merged Hanicef requested to merge Hanicef/SRB2Classic:fix-buffer-overflow-dedicated into next

When registering a server that runs on the dedicated server build on Unix, the server could potentially crash due to a buffer overflow when allocating a thread condition, as the allocation was incorrectly configured to allocate a thread_t instead of a thread_cond_t. The bug itself occurs very inconsistently since it relies on a race condition to trigger, so reproducing the bug might not be the easiest to do.

Merge request reports

Pipeline #5675 passed

Pipeline passed for 6dbcd2ba on Hanicef:fix-buffer-overflow-dedicated

Approval is optional

Merged by LactozillaLactozilla 6 months ago (Oct 7, 2024 7:25pm UTC)

Merge details

  • Changes merged into with 987d2ee5.
  • Deleted the source branch.

Pipeline #5739 passed

Pipeline passed for 987d2ee5 on next

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading