Fixer mixer: Mixer Memory Leaks (!287) · Merge requests · STJr / SRB2

Merged Sryder requested to merge Sryder/SRB2:fixer-mixer into master 6 years ago

Oct 07, 2018

Fix the crashing bug hopefully · fb6c3298

Sryder authored 6 years ago

A value of 1 in freesrc for Mix_LoadWAV_RW and Mix_LoadMus_RW calls SDL_RWclose on the RWops anyway.
For Mix_LoadWAV_RW the RWops is freed right after the data is loaded (because it makes a copy of the data in memory)
For Mix_LoadMUS_RW the RWops is freed when Mix_FreeMusic is called (because the data is not a copy)
So setting 1 on freesrc doesn't actually free the RWops immediately on Mix_LoadMus_RW *unless* it failed to load any music.

fb6c3298

Fix compiler warnings. · 02597e0b
Sryder authored 6 years ago

02597e0b

Oct 06, 2018
- I think that should be NULL, not 0 actually. · d072dd27
  Sryder authored 6 years ago
  
  d072dd27
- Mix_QuickLoad_RAW sets a flag in the Mix_Chunk so that Mix_FreeChunk doesn't... · 7b417b57
  Sryder authored 6 years ago
  
  Mix_QuickLoad_RAW sets a flag in the Mix_Chunk so that Mix_FreeChunk doesn't actually Free the sound. Checks for the flag when freeing, and if it's 0, we free the data manually after Mix_FreeChunk. I went back to Z_Malloc and Z_Free for this because they still work after this.
  7b417b57
- Call SDL_RWclose after an SDL_RWFromMem call to close the RWops. · 725a65c1
  Sryder authored 6 years ago
  
  725a65c1

Fixer mixer: Mixer Memory Leaks

Merge request reports

Activity