Make mappable buttons for System Menu, Screenshot, Movie, and Viewpoint

Hey Kart Krew, can we have this? I took gc_systemmenu, gc_screenshot, gc_recordgif, and gc_viewpoint so we can have those for controllers.

@toaster

added 1 commit

• 06faf6ff - Unneeded input header in st_stuff

Compare with previous version

added 1 commit

• 6ca11305 - Hardcode Screenshot, GIF, and Viewpoint to their F keys

Compare with previous version

Sure you can have it!! I was meaning to make a backport of a bunch of stuff from Kart for the 2.1 repository after we released, but life is obliterating me right now.

If you want to give it a quick shot before 2.1.21, I was planning to do the add-ons menu (in its enhanced, scrollbar-toting kart forme minus the support for .kart files, rather than a 1:1 recreation of the internal version).

Feel free to ask about as many things as you want to, anyways. Menu stuff is basically all me except for the character select menu, so I think all that'd be fine; I think 4P and Encore are the only things explicitly "off-limits" for the vanilla game, at least for now (we might reconsider in a year or so), but it's worth checking individually for all other playsim-affecting features you might want to share.

Thanks, I like to ask because it's good to maintain a bridge :)

.21's getting fast-tracked now. If you did backport addons, I would say that's worth a .22 release. Don't know the rest of the team's opinion though, but I don't think the objections would be strong so long as someone was willing to run the release horse (e.g., me).

Guess it might depend on how long til 2.2 :P

Out of curiosity, how long would you estimate it takes to port it? @toaster

merged

mentioned in commit 8471c416

Oh, I was saying for you to backport it; it took about two days to get it done for kart, but I have merge requests and records for everything I can check. Right now I'm struggling to get out of bed for university work, so I won't be in a good position to do the legwork on it.

Well you may have just issued me a challenge

(btw #git-feeders NO DON'T COUNT ON THIS MAKING IT!!!)

https://git.magicalgirl.moe/KartKrew/Kart-Public/commit/8bc1a217fe9785a84ed783eb4317741bc7f4e696

Full merge diff if you wanna go ham! Look in Kart's gfx.kart for the necessary lumps for patch.dta. Makes a (non-packet-breaking) change to how the "list of added files" is constructed for the MS/joiners to completely ignore music-only files in order to eke a tad more out of the existing MAXFILENEEDED limitation, a change which is present in both Kart and internal but not public or next. Godspeed!

Known issue: on Mac/Linux, filesystem does not provide files in alphabetical order. Fine for "search" (technically more of a filter, but search is more obviously useful) for specifics, but frustrating to navigate as there is no other way to organise in-game. If it's a complicated fix, and would require specifically written at-runtime-sorting - don't bother - but if it turns out it's a single bitflag or parameter to the file/folder library SRB2's using then you'd probably be in the best position out of everyone who's looked at this code to identify a quick way to improve it!

Thanks, appreciate the advice we'll see if I come across it. Maybe Steel knows a thing about the Linux filesystem that I wouldn't :X