MinGW64:Target nocona for 64-bit builds [revision]

Revision of !438 (closed)

Per discussion, -march=nocona is only set when X86_64=1. LINUX64=1 does not set this flag.

MINGW64=1 does currently set this flag, but only because we assume x86-64 in src/win32/makefile.cfg. If we stop assuming x86-64 in the future, then X86_64 should not be set by MINGW64 at that time.

M5 is also renamed to ARCHOPTS and can be overridden by command line.

I forgot, variable names can't begin with a digit, according to Bash. Change that and we are golden

Done

mentioned in merge request !438 (closed)

I want this merged because I'm adding 64-bit builds to appveyor and I do not want to explicitly add -march=nocona to that config.

This passes the 64-bit buildbot: https://ci.appveyor.com/project/mazmazz/srb2/builds/21289946/job/hgwrqhqml670il8e

Config: https://github.com/mazmazz/SRB2/blob/appveyor-64/appveyor.yml

Looks good to me! Having consistency is also nice.

mentioned in merge request !442 (merged)

mentioned in merge request KartKrew/Kart-Public!7 (merged)

added 10 commits

• 34534428 - Add 64-bit SDL builds to appveyor config
• 2aa7ee70 - Disable UPX by default in appveyor
• 0fc07eba - Consolidate [%CONFIGURATION%] == [SDL64] into %X86_64%
• e7165444 - Add 64-bit DD buildbot
• bef0bc82 - Merge branch 'mingw-64bit-cpu-target-revise' into appveyor-64
• 941e2978 - Implement install building for appveyor (deployer)
• e1300d51 - Rename ASSET_PATCH_DLL_GET to PACKAGE_PATCH_DLL_GET
• f00cfb7b - Use optional asset archive instead of file
• bd81c319 - Merge branch 'appveyor-deployer' into 'appveyor-64'
• ce7875b1 - Merge branch 'appveyor-64' into 'mingw-64bit-cpu-target-revise'

Compare with previous version

The ARCHOPTS blocks are being run correctly, and the AppVeyor installers (merged from !443 (merged)) are correct, so merging.

One minor concern about the AppVeyor installers is that I don't compile with -static-libgcc in the appveyor config, so the EXEs could potentially have a libgcc-...dll dependency later.

Dependency Walker shows that they currently do NOT have this dependency, even without -static-libgcc, so I hesitated to add a CFLAG that seems unnecessary. Maybe that can be added later.

AppVeyor results: https://ci.appveyor.com/project/mazmazz/srb2/builds/21318790

merged

mentioned in commit bbd878e5