Skip to content
Snippets Groups Projects

Resolve buffer overflow crash when configuring System Menu and GIF controls

Merged mazmazz requested to merge changecontrol-text-overflow-fix into master

This crash happened in OSX and Linux builds immediately upon attempting to config the System Menu and GIF controls.

The issue is that the program was trying to build the string,

Press a key for
Toggle GIF Recording
ESC to cancel

and the control name for Toggle GIF Recording overflowed the string buffer by 2 chars.

I increased that buffer to support up to a 32 character control name for that template.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading