Skip to content
Snippets Groups Projects

Fof flag change hotfix

Merged Fof flag change hotfix
fof-flag-change-hotfix into next
Merged Monster Iestyn requested to merge fof-flag-change-hotfix into next

This fixes rendering issues caused by changing FOF flags mid-level via Lua or linedef type 445. Everything else that toggles FF_EXISTS already had this fix it turns out.

Not sure if this is safe for master too, could someone check that for me?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/lua_maplib.c
1111 1111 case ffloor_bottompic:
1112 1112 *ffloor->bottompic = P_AddLevelFlatRuntime(luaL_checkstring(L, 3));
1113 1113 break;
1114 case ffloor_flags:
1114 case ffloor_flags: {
  • Monster Iestyn
    Monster Iestyn @MonsterIestyn started a thread on the diff
    • src/lua_maplib.c
    1111 1111 case ffloor_bottompic:
    1112 1112 *ffloor->bottompic = P_AddLevelFlatRuntime(luaL_checkstring(L, 3));
    1113 1113 break;
    1114 case ffloor_flags:
    1114 case ffloor_flags: {
    • Monster Iestyn
      Monster Iestyn @MonsterIestyn ·
      Author Contributor

      because of the declaration in the line below, "ffloortype_e oldflags = ffloor->flags;". Or is {} not needed for that in a switch case?

  • Alam Ed Arias
    Alam Ed Arias @Alam started a thread on the diff
    • src/lua_maplib.c
    1111 1111 case ffloor_bottompic:
    1112 1112 *ffloor->bottompic = P_AddLevelFlatRuntime(luaL_checkstring(L, 3));
    1113 1113 break;
    1114 case ffloor_flags:
    1114 case ffloor_flags: {
    • Alam Ed Arias
      Alam Ed Arias @Alam ·
      Maintainer

      No, I had moved ffloortype_e oldflags to the top of the function just to avoid alloc on the stack, but that my silly stick

  • Inuyasha Status changed to merged

    Status changed to merged

  • Inuyasha mentioned in commit 4bb71439

    mentioned in commit 4bb71439

    • Please register or sign in to reply