Skip to content
Snippets Groups Projects

Polyobj waypoint thinker optimise

Merged Monster Iestyn requested to merge polyobj-waypoint-thinker-optimise into next
All threads resolved!

An attempt at optimising the thinker for PolyObjects that follow waypoint. In particular, a pointer to the waypoint the PolyObject is currently going to is introduced, so the waypoint thinker doesn't have to go through the entire mobj thinker list every tic just to re-find the next waypoint every time.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by avatar (May 4, 2025 8:02am UTC)

Merge details

  • Changes merged into with b5df2d5c.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • toaster
  • Monster Iestyn added 1 commit

    added 1 commit

    • 1d04001f - use P_SetTarget to assign a value to th->target

    Compare with previous version

  • Monster Iestyn resolved all discussions

    resolved all discussions

    • toaster @toaster commented on commit 1d04001f
      Contributor

      Probably should also check for P_MobjWasRemoved to NULL target before the loop?

    • I could but tbh waypoints aren't likely to be removed mid-game by anything except via Lua scripts, so I'm not sure whether it's necessary to consider the possibility

    • Contributor

      I would recommend it personally but can't singlehandedly make you do it and am too tired to do it myself so whatever

    • Please register or sign in to reply
  • SteelT
  • Monster Iestyn added 1 commit

    added 1 commit

    • 7c9b1ee2 - Fix P_SetTarget crash by setting th->target to NULL first

    Compare with previous version

  • SteelT resolved all discussions

    resolved all discussions

  • merged

  • James R. mentioned in commit b5df2d5c

    mentioned in commit b5df2d5c

  • Please register or sign in to reply
    Loading